mirrors/alsa-lib
1
0
Fork 0
mirror of https://github.com/alsa-project/alsa-lib.git synced 2025-11-04 13:30:08 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

pcm: rate: Fix compile warning wrt bit ops and comparison

Browse source 
We've got a gcc warning:
  pcm_rate.c: In function ‘snd_pcm_rate_drain’:
  pcm_rate.c:1090:19: warning: suggest parentheses around comparison in operand of ‘&’ [-Wparentheses]
     if (pcm->mode & SND_PCM_NONBLOCK != 0) {
                   ^

Drop the zero comparison for fixing the warning and for simplicity.

Fixes: 29041c5220 ("fix infinite draining of the rate plugin in SND_PCM_NONBLOCK mode")
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Takashi Iwai 2020-05-11 16:27:31 +02:00
parent 76c098bf6e
commit c04d7bbd6c
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/pcm/pcm_rate.c
View file

@ -1087,7 +1087,7 @@ static int snd_pcm_rate_drain(snd_pcm_t *pcm)
if (rate->last_commit_ptr >= pcm->boundary) if (rate->last_commit_ptr >= pcm->boundary)
rate->last_commit_ptr = 0; rate->last_commit_ptr = 0;
} else if (commit_err == 0) { } else if (commit_err == 0) {
if (pcm->mode & SND_PCM_NONBLOCK != 0) { if (pcm->mode & SND_PCM_NONBLOCK) {
commit_err = -EAGAIN; commit_err = -EAGAIN;
break; break;
} }