mirrors/alsa-lib
1
0
Fork 0
mirror of https://github.com/alsa-project/alsa-lib.git synced 2025-11-02 09:01:48 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

mixer: remove alloca() from elem_write_enum()

Browse source 
Both of alloca() and automatic variables keep storages on stack, while
the former generates more instructions than the latter. It's better to use
the latter if the size of storage is computable at pre-compile or compile
time; i.e. just for structures.

This commit obsolete usages of alloca() with automatic variables.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Takashi Sakamoto 2016-07-15 09:23:20 +09:00 • committed by Takashi Iwai
parent 5ca104cf15
commit bd09e4790c
1 changed files with 4 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/mixer/simple_none.c
View file

@ -532,7 +532,7 @@ static int elem_write_route(selem_none_t *s, int dir, selem_ctl_type_t type)
static int elem_write_enum(selem_none_t *s)
{
snd_ctl_elem_value_t *ctl;
snd_ctl_elem_value_t ctl = {0};
unsigned int idx;
int err;
int type;
@ -546,13 +546,12 @@ static int elem_write_enum(selem_none_t *s)
else if (s->selem.caps & SM_CAP_CENUM)
type = CTL_CAPTURE_ENUM;
c = &s->ctls[type];
snd_ctl_elem_value_alloca(&ctl);
if ((err = snd_hctl_elem_read(c->elem, ctl)) < 0)
if ((err = snd_hctl_elem_read(c->elem, &ctl)) < 0)
return err;
for (idx = 0; idx < c->values; idx++)
snd_ctl_elem_value_set_enumerated(ctl, idx,
snd_ctl_elem_value_set_enumerated(&ctl, idx,
(unsigned int)s->str[0].vol[idx]);
if ((err = snd_hctl_elem_write(c->elem, ctl)) < 0)
if ((err = snd_hctl_elem_write(c->elem, &ctl)) < 0)
return err;
return 0;
}