mirrors/alsa-lib
1
0
Fork 0
mirror of https://github.com/alsa-project/alsa-lib.git synced 2025-10-29 05:40:25 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

pcm: dmix: fix wrong scaling in 32bits pcm mixing

Browse source 
Generic mixing function for 32bits pcm has used 8bits right shift for
pre-scaling. But this is generating wrong result if pcm data is
negative value because return value type of bswap_32() is unsigned int.

This patch adds type cast bswap_32() result to signed int.

Fixes: https://github.com/alsa-project/alsa-lib/pull/222
Signed-off-by: Katsuhiro Suzuki <katsuhiro@katsuster.net>
Signed-off-by: Jaroslav Kysela <perex@perex.cz>
This commit is contained in:
Katsuhiro Suzuki 2022-04-29 01:17:27 +09:00 • committed by Jaroslav Kysela
parent a513e65e19
commit b62fc061e4
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/pcm/pcm_dmix_generic.c
View file

@ -330,7 +330,7 @@ static void generic_mix_areas_32_swap(unsigned int size,
register signed int sample; register signed int sample;
for (;;) { for (;;) {
sample = bswap_32(*src) >> 8; sample = (signed int) bswap_32(*src) >> 8;
if (! *dst) { if (! *dst) {
*sum = sample; *sum = sample;
*dst = *src; *dst = *src;
@ -364,7 +364,7 @@ static void generic_remix_areas_32_swap(unsigned int size,
register signed int sample; register signed int sample;
for (;;) { for (;;) {
sample = bswap_32(*src) >> 8; sample = (signed int) bswap_32(*src) >> 8;
if (! *dst) { if (! *dst) {
*sum = -sample; *sum = -sample;
*dst = bswap_32(-sample); *dst = bswap_32(-sample);