mirrors/alsa-lib
1
0
Fork 0
mirror of https://github.com/alsa-project/alsa-lib.git synced 2025-11-03 09:01:52 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

conf: remove alloca() from snd_determine_driver()

Browse source 
Both of alloca() and automatic variables keeps storages on stack, while
the former generates more instructions than the latter. It's better to use
the latter if the size of storage is computable at pre-compile or compile
time; i.e. just for structures.

This commit obsolete usages of alloca() with automatic variables.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Takashi Sakamoto 2016-07-14 23:07:40 +09:00 • committed by Takashi Iwai
parent d745fcd5f7
commit b500e16ce4
1 changed files with 3 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/confmisc.c
View file

@ -664,7 +664,7 @@ SND_DLSYM_BUILD_VERSION(snd_func_private_string, SND_CONFIG_DLSYM_VERSION_EVALUA
int snd_determine_driver(int card, char **driver) int snd_determine_driver(int card, char **driver)
{ {
snd_ctl_t *ctl = NULL; snd_ctl_t *ctl = NULL;
snd_ctl_card_info_t *info; snd_ctl_card_info_t info = {0};
char *res = NULL; char *res = NULL;
int err; int err;
@ -674,13 +674,12 @@ int snd_determine_driver(int card, char **driver)
SNDERR("could not open control for card %i", card); SNDERR("could not open control for card %i", card);
goto __error; goto __error;
} }
snd_ctl_card_info_alloca(&info); err = snd_ctl_card_info(ctl, &info);
err = snd_ctl_card_info(ctl, info);
if (err < 0) { if (err < 0) {
SNDERR("snd_ctl_card_info error: %s", snd_strerror(err)); SNDERR("snd_ctl_card_info error: %s", snd_strerror(err));
goto __error; goto __error;
} }
res = strdup(snd_ctl_card_info_get_driver(info)); res = strdup(snd_ctl_card_info_get_driver(&info));
if (res == NULL) if (res == NULL)
err = -ENOMEM; err = -ENOMEM;
else { else {