This commit is contained in:
Mike Gilbert 2026-01-31 00:33:33 +00:00 committed by GitHub
commit a0b5c5ee09
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -183,7 +183,7 @@ static int parse_args(char ***argv, int argc, const char *cmd)
*/ */
int uc_mgr_exec(const char *prog) int uc_mgr_exec(const char *prog)
{ {
pid_t p, f; pid_t p;
int err = 0, status; int err = 0, status;
char bin[PATH_MAX]; char bin[PATH_MAX];
struct sigaction sa; struct sigaction sa;
@ -239,7 +239,7 @@ int uc_mgr_exec(const char *prog)
} }
if (p == 0) { if (p == 0) {
f = open("/dev/null", O_RDWR); int f = open("/dev/null", O_RDWR);
if (f == -1) { if (f == -1) {
snd_error(UCM, "pid %d cannot open /dev/null for redirect %s -- %s", snd_error(UCM, "pid %d cannot open /dev/null for redirect %s -- %s",
getpid(), prog, strerror(errno)); getpid(), prog, strerror(errno));
@ -261,7 +261,7 @@ int uc_mgr_exec(const char *prog)
closefrom(3); closefrom(3);
#else #else
{ {
pid_t maxfd = sysconf(_SC_OPEN_MAX); long maxfd = sysconf(_SC_OPEN_MAX);
for (f = 3; f < maxfd; f++) for (f = 3; f < maxfd; f++)
close(f); close(f);
} }
@ -287,8 +287,8 @@ int uc_mgr_exec(const char *prog)
setpgid(p, p); setpgid(p, p);
while (1) { while (1) {
f = waitpid(p, &status, 0); pid_t r = waitpid(p, &status, 0);
if (f == -1) { if (r == -1) {
if (errno == EAGAIN) if (errno == EAGAIN)
continue; continue;
err = -errno; err = -errno;