mirrors/alsa-lib
1
0
Fork 0
mirror of https://github.com/alsa-project/alsa-lib.git synced 2025-11-07 13:30:07 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

pcm: remove alloca() from _snd_pcm_hook_ctl_elems_install()

Browse source 
Both of alloca() and automatic variables keeps storages on stack, while
the former generates more instructions than the latter. It's better to use
the latter if the size of storage is computable at pre-compile or compile
time; i.e. just for structures.

This commit obsolete usages of alloca() with automatic variables.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Takashi Sakamoto 2016-07-14 23:07:28 +09:00 • committed by Takashi Iwai
parent f7c60897d9
commit 955d989e81
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/pcm/pcm_hooks.c
View file

@ -667,7 +667,7 @@ int _snd_pcm_hook_ctl_elems_install(snd_pcm_t *pcm, snd_config_t *conf)
{
int err;
int card;
snd_pcm_info_t *info;
snd_pcm_info_t info = {0};
char ctl_name[16];
snd_ctl_t *ctl;
snd_sctl_t *sctl = NULL;
@ -675,11 +675,11 @@ int _snd_pcm_hook_ctl_elems_install(snd_pcm_t *pcm, snd_config_t *conf)
snd_pcm_hook_t *h_hw_params = NULL, *h_hw_free = NULL, *h_close = NULL;
assert(conf);
assert(snd_config_get_type(conf) == SND_CONFIG_TYPE_COMPOUND);
snd_pcm_info_alloca(&info);
err = snd_pcm_info(pcm, info);
err = snd_pcm_info(pcm, &info);
if (err < 0)
return err;
card = snd_pcm_info_get_card(info);
card = snd_pcm_info_get_card(&info);
if (card < 0) {
SNDERR("No card for this PCM");
return -EINVAL;