mirrors/alsa-lib
1
0
Fork 0
mirror of https://github.com/alsa-project/alsa-lib.git synced 2025-11-02 09:01:48 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

mixer: remove alloca() from init_db_range()

Browse source 
Both of alloca() and automatic variables keep storages on stack, while
the former generates more instructions than the latter. It's better to use
the latter if the size of storage is computable at pre-compile or compile
time; i.e. just for structures.

This commit obsolete usages of alloca() with automatic variables.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Takashi Sakamoto 2016-07-15 09:23:26 +09:00 • committed by Takashi Iwai
parent 1ad6d7b852
commit 6ed7471573
1 changed files with 3 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/mixer/simple_none.c
View file

@ -1098,7 +1098,7 @@ static int convert_to_dB(snd_hctl_elem_t *ctl, struct selem_str *rec,
*/
static int init_db_range(snd_hctl_elem_t *ctl, struct selem_str *rec)
{
snd_ctl_elem_info_t *info;
snd_ctl_elem_info_t info = {0};
unsigned int *tlv = NULL;
const unsigned int tlv_size = 4096;
unsigned int *dbrec;
@ -1109,10 +1109,9 @@ static int init_db_range(snd_hctl_elem_t *ctl, struct selem_str *rec)
if (rec->db_initialized)
return 0;
snd_ctl_elem_info_alloca(&info);
if (snd_hctl_elem_info(ctl, info) < 0)
if (snd_hctl_elem_info(ctl, &info) < 0)
goto error;
if (!snd_ctl_elem_info_is_tlv_readable(info))
if (!snd_ctl_elem_info_is_tlv_readable(&info))
goto error;
tlv = malloc(tlv_size);
if (!tlv)