mirrors/alsa-lib
1
0
Fork 0
mirror of https://github.com/alsa-project/alsa-lib.git synced 2025-11-02 09:01:48 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

ucm: fix crash when calling snd_use_case_geti() with no device or modifier

Browse source 
When calling snd_use_case_geti(uc_mgr, "_devstatus", &lvalue) the code
ends up calling device_status(uc_mgr, NULL), which result in a crash in
strcmp(dev->name, NULL), when there are enabled devices.

This happens because snd_use_case_geti() allows a "_devstatus"
identifier even if it's only supposed to allow the form
"_devstatus/{device}".

So check that the device name is not null.

The same issue occurs with "_modstatus", this change fixes that as well.

Signed-off-by: Antonio Ospite <ao2@ao2.it>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Antonio Ospite 2016-09-23 18:11:16 +02:00 • committed by Takashi Iwai
parent 0fc4b4d17b
commit 4ec907c773
1 changed files with 8 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/ucm/main.c
View file

@ -1528,12 +1528,20 @@ int snd_use_case_geti(snd_use_case_mgr_t *uc_mgr,
str = NULL; str = NULL;
} }
if (check_identifier(identifier, "_devstatus")) { if (check_identifier(identifier, "_devstatus")) {
if (!str) {
err = -EINVAL;
goto __end;
}
err = device_status(uc_mgr, str); err = device_status(uc_mgr, str);
if (err >= 0) { if (err >= 0) {
*value = err; *value = err;
err = 0; err = 0;
} }
} else if (check_identifier(identifier, "_modstatus")) { } else if (check_identifier(identifier, "_modstatus")) {
if (!str) {
err = -EINVAL;
goto __end;
}
err = modifier_status(uc_mgr, str); err = modifier_status(uc_mgr, str);
if (err >= 0) { if (err >= 0) {
*value = err; *value = err;