mirrors/alsa-lib
1
0
Fork 0
mirror of https://github.com/alsa-project/alsa-lib.git synced 2025-11-03 09:01:52 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

ucm: uc_mgr_substitute_tree() fix use after free

Browse source 
Signed-off-by: Jaroslav Kysela <perex@perex.cz>
This commit is contained in:
Jaroslav Kysela 2021-01-07 17:41:38 +01:00
parent 51e1d486ce
commit 3f63dc2644
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/ucm/ucm_subs.c
View file

@ -417,11 +417,12 @@ int uc_mgr_substitute_tree(snd_use_case_mgr_t *uc_mgr, snd_config_t *node)
if (err < 0) if (err < 0)
return err; return err;
err = snd_config_set_id(node, s); err = snd_config_set_id(node, s);
free(s);
if (err < 0) { if (err < 0) {
uc_error("unable to set substituted id '%s' (old id '%s')", s, id); uc_error("unable to set substituted id '%s' (old id '%s')", s, id);
free(s);
return err; return err;
} }
free(s);
} }
if (snd_config_get_type(node) != SND_CONFIG_TYPE_COMPOUND) { if (snd_config_get_type(node) != SND_CONFIG_TYPE_COMPOUND) {
if (snd_config_get_type(node) == SND_CONFIG_TYPE_STRING) { if (snd_config_get_type(node) == SND_CONFIG_TYPE_STRING) {