pcm: Insert linear-to-float conversion when rate or channel count is incorrect

This fixes a bug where snd_pcm_plug_insert_plugins fails when both
client and slave use format float, but the rate or channel count does
not match. I also removed some redundant code.

Signed-off-by: Maarten Baert <maarten-baert@hotmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Maarten Baert 2014-02-26 14:23:45 +01:00 committed by Takashi Iwai
parent b669b50de2
commit 2da7b0c2c1

View file

@ -522,15 +522,13 @@ static int snd_pcm_plug_change_format(snd_pcm_t *pcm, snd_pcm_t **new, snd_pcm_p
}
#ifdef BUILD_PCM_PLUGIN_LFLOAT
} else if (snd_pcm_format_float(slv->format)) {
/* Conversion is done in another plugin */
if (clt->format == slv->format &&
clt->rate == slv->rate &&
clt->channels == slv->channels)
return 0;
cfmt = clt->format;
if (snd_pcm_format_linear(clt->format))
if (snd_pcm_format_linear(clt->format)) {
cfmt = clt->format;
f = snd_pcm_lfloat_open;
else
} else if (clt->rate != slv->rate || clt->channels != slv->channels) {
cfmt = SND_PCM_FORMAT_S16;
f = snd_pcm_lfloat_open;
} else
return -EINVAL;
#endif
#ifdef BUILD_PCM_NONLINEAR