mirrors/alsa-lib
1
0
Fork 0
mirror of https://github.com/alsa-project/alsa-lib.git synced 2025-11-03 09:01:52 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

mixer: remove alloca() from elem_write_route()

Browse source 
Both of alloca() and automatic variables keep storages on stack, while
the former generates more instructions than the latter. It's better to use
the latter if the size of storage is computable at pre-compile or compile
time; i.e. just for structures.

This commit obsolete usages of alloca() with automatic variables.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Takashi Sakamoto 2016-07-15 09:23:22 +09:00 • committed by Takashi Iwai
parent 5268e90dbd
commit 2a6af83d73
1 changed files with 5 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

11
src/mixer/simple_none.c
View file

@ -514,19 +514,18 @@ static int elem_write_switch_constant(selem_none_t *s, selem_ctl_type_t type, in
static int elem_write_route(selem_none_t *s, int dir, selem_ctl_type_t type) static int elem_write_route(selem_none_t *s, int dir, selem_ctl_type_t type)
{ {
snd_ctl_elem_value_t *ctl; snd_ctl_elem_value_t ctl = {0};
unsigned int idx; unsigned int idx;
int err; int err;
selem_ctl_t *c = &s->ctls[type]; selem_ctl_t *c = &s->ctls[type];
snd_ctl_elem_value_alloca(&ctl); if ((err = snd_hctl_elem_read(c->elem, &ctl)) < 0)
if ((err = snd_hctl_elem_read(c->elem, ctl)) < 0)
return err; return err;
for (idx = 0; idx < c->values * c->values; idx++) for (idx = 0; idx < c->values * c->values; idx++)
snd_ctl_elem_value_set_integer(ctl, idx, 0); snd_ctl_elem_value_set_integer(&ctl, idx, 0);
for (idx = 0; idx < c->values; idx++) for (idx = 0; idx < c->values; idx++)
snd_ctl_elem_value_set_integer(ctl, idx * c->values + idx, snd_ctl_elem_value_set_integer(&ctl, idx * c->values + idx,
!!(s->str[dir].sw & (1 << idx))); !!(s->str[dir].sw & (1 << idx)));
if ((err = snd_hctl_elem_write(c->elem, ctl)) < 0) if ((err = snd_hctl_elem_write(c->elem, &ctl)) < 0)
return err; return err;
return 0; return 0;
} }