mirrors/alsa-lib
1
0
Fork 0
mirror of https://github.com/alsa-project/alsa-lib.git synced 2025-11-04 13:30:08 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

pcm: route: Remove bogus ! in snd_config_get_id() checks

Browse source 
There are strange "!" added before snd_config_get_id() return value
checks in a couple of places in pcm_route.c.  This essentially makes
the result always positive, making checks bogus.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Takashi Iwai 2015-09-08 21:48:17 +02:00
parent fe8bb1fe02
commit 03d6b15291
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/pcm/pcm_route.c
View file

@ -770,7 +770,7 @@ static int determine_chmap(snd_config_t *tt, snd_pcm_chmap_t **tt_chmap)
snd_config_iterator_t j, jnext; snd_config_iterator_t j, jnext;
snd_config_t *in = snd_config_iterator_entry(i); snd_config_t *in = snd_config_iterator_entry(i);
if (!snd_config_get_id(in, &id) < 0) if (snd_config_get_id(in, &id) < 0)
continue; continue;
if (snd_config_get_type(in) != SND_CONFIG_TYPE_COMPOUND) if (snd_config_get_type(in) != SND_CONFIG_TYPE_COMPOUND)
goto err; goto err;
@ -1070,7 +1070,7 @@ static int _snd_pcm_route_determine_ttable(snd_config_t *tt,
snd_config_iterator_t j, jnext; snd_config_iterator_t j, jnext;
long cchannel; long cchannel;
const char *id; const char *id;
if (!snd_config_get_id(in, &id) < 0) if (snd_config_get_id(in, &id) < 0)
continue; continue;
err = safe_strtol(id, &cchannel); err = safe_strtol(id, &cchannel);
if (err < 0) { if (err < 0) {